-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Update to gcc10 #3752
build: Update to gcc10 #3752
Conversation
Dec 11, 2020 release is now 10.2: |
The SAMD51 builds I think that use |
As of gcc 10: -finline-functions is now enabled at -O2 (https://gcc.gnu.org/gcc-10/changes.html). This may explain the large growth of |
This resolves the build error ``` arm-none-eabi-ld: build-spresense/libmpy.a(Camera.o):(.rodata.camera_imageformat_type+0x0): multiple definition of `camera_imageformat_type'; build-spresense/libmpy.a(__init__.o):(.rodata.camera_imageformat_type+0x0): first defined here arm-none-eabi-ld: build-spresense/libmpy.a(ImageFormat.o):(.rodata.camera_imageformat_type+0x0): multiple definition of `camera_imageformat_type'; build-spresense/libmpy.a(__init__.o):(.rodata.camera_imageformat_type+0x0): first defined here arm-none-eabi-ld: build-spresense/libmpy.a(Camera.o):(.rodata.camera_imageformat_type+0x0): multiple definition of `camera_imageformat_type'; build-spresense/libmpy.a(__init__.o):(.rodata.camera_imageformat_type+0x0): first defined here ```
…r -O2; fix struct init in HCI bleio
@hierophect Take note too. This will not affect the ESP32-S2 builds, since they have their own toolchain, but the STM builds would change. |
@dhalbert noted. What steps in particular are required? I assume I'll want to go back into my notes to reinstall the toolchain, and are all the makefiles changing as well? A list of upgrade steps might be beneficial to all. |
FYI -- for the Raspberry Pi aficionados, I am compiling a toolchain for the Raspberry Pi -- takes about 8 hours -- it's 4 hours into it ... if it succeed,, I'll make it available as I have in the past. Hopefully soon after it is merged into main and I have a chance to test it. |
I am testing this PR with My Raspberry Pi build -- I noticed the when I switch to this PR there are some changes made to the underlying repo I was able to build the atmel-samd/matrixportal_m4 with my newly compiled gcc-10 so I think the compiler is OK |
This PR was started quite a while ago, so working at that commit does not include a bunch of changes. The PR test merge commits are more interesting. |
@dhalbert OK -- I don't think there is any problem - just want to be sure I understood. My new compiler seem OK on the Pi and Jeff has made it available to anyone who wants it. Ready when this gets merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with this! Thanks for doing the final switch.
I think the next step is to do some smoke tests with gcc10 firmware buildsand see that they work on some sample programs. Then we can notify @ circuitpythonistas, and also I will update the Building CircuitPython guide. |
I did some smoke tests and am satisfied. |
No description provided.